Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API for widgets to return possible bind values #1600

Merged
merged 23 commits into from
Dec 6, 2021
Merged

Conversation

Pangoraw
Copy link
Collaborator

@Pangoraw Pangoraw commented Oct 26, 2021

@fonsp
Copy link
Owner

fonsp commented Nov 2, 2021

Can use the new stuff from #1612 !

@Pangoraw Pangoraw marked this pull request as ready for review November 3, 2021 22:39
@fonsp
Copy link
Owner

fonsp commented Nov 8, 2021

I just realised: the possible bind values should stay in the notebook process, because they might not be serializable...... You only want the outside process to know the length, and to say e.g. "set bound variable x to the 17th possible value". Will come back to this next week!

@fonsp fonsp marked this pull request as draft November 8, 2021 23:14
@Pangoraw
Copy link
Collaborator Author

Pangoraw commented Nov 8, 2021

I think the collected values should correspond to the JavaScript possible values so they should be serializable. If we collect Julia values then the Message pack hashes for the files will be wrong. The Julia can still be found by using the js->jl transform. Also see JuliaPluto/PlutoUI.jl#152.

@fonsp fonsp marked this pull request as ready for review November 15, 2021 21:57
src/runner/PlutoRunner.jl Outdated Show resolved Hide resolved
@fonsp

This comment has been minimized.

@fonsp fonsp marked this pull request as draft November 16, 2021 19:34
@fonsp fonsp marked this pull request as ready for review November 29, 2021 17:25
@fonsp fonsp merged commit d60123b into main Dec 6, 2021
@Pangoraw Pangoraw deleted the possible_bind_values branch March 21, 2022 10:06
@fonsp fonsp added PlutoSliderServer backend Concerning the julia server and runtime PlutoDesktop labels Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Concerning the julia server and runtime PlutoDesktop PlutoSliderServer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants