Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct communication link between user JS and JL for JSServe support #2392

Closed
wants to merge 29 commits into from

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Nov 24, 2022

Split off from #991. This PR is a subset of #991, only adding the simple JS-JL link, without WebIO support, and without AssetRegistry support.

We decided to work on supporting JSServe instead of WebIO because JSServe is being actively maintained and developed (SimonDanisch/Bonito.jl#118), while WebIO and its dependencies are not developed/maintained as much, and they are currently not compatible with HTTP 1.0, which is painful for the Julia ecosystem.

JSServe will also be easier to support, especially in Pluto's HTML Export, as it does not require hooking into the HTTP server. Instead, it uses data URIs, and maybe #1124 to transfer data.

This will add stable out-of-the-box support for WGLMakie!!

Thanks @dralletje for the initial work for this PR!

TODO:

@github-actions
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="js-jl-link-for-jsserve")
julia> using Pluto

@fonsp fonsp mentioned this pull request Nov 30, 2022
@fonsp fonsp added enhancement New feature or request frontend Concerning the HTML editor backend Concerning the julia server and runtime HTTP/WS The connection between backend and frontend other packages Integration with other Julia packages labels Apr 26, 2023
@disberd
Copy link
Contributor

disberd commented May 12, 2023

@fonsp is there any way to help with this PR?
I think it would really enable a lot of cool functionality (look at all the internal refs to this PR) and it's a pity that is basically stale since quite a while

@fonsp
Copy link
Owner Author

fonsp commented Nov 21, 2023

Replaced by #2726

@fonsp fonsp closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Concerning the julia server and runtime enhancement New feature or request frontend Concerning the HTML editor HTTP/WS The connection between backend and frontend other packages Integration with other Julia packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants