-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct communication link between user JS and JL for JSServe support #2392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="js-jl-link-for-jsserve")
julia> using Pluto |
fonsp
added
enhancement
New feature or request
frontend
Concerning the HTML editor
backend
Concerning the julia server and runtime
HTTP/WS
The connection between backend and frontend
other packages
Integration with other Julia packages
labels
Apr 26, 2023
@fonsp is there any way to help with this PR? |
14 tasks
Replaced by #2726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
Concerning the julia server and runtime
enhancement
New feature or request
frontend
Concerning the HTML editor
HTTP/WS
The connection between backend and frontend
other packages
Integration with other Julia packages
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #991. This PR is a subset of #991, only adding the simple JS-JL link, without WebIO support, and without AssetRegistry support.
We decided to work on supporting JSServe instead of WebIO because JSServe is being actively maintained and developed (SimonDanisch/Bonito.jl#118), while WebIO and its dependencies are not developed/maintained as much, and they are currently not compatible with HTTP 1.0, which is painful for the Julia ecosystem.
JSServe will also be easier to support, especially in Pluto's HTML Export, as it does not require hooking into the HTTP server. Instead, it uses data URIs, and maybe #1124 to transfer data.
This will add stable out-of-the-box support for WGLMakie!!
Thanks @dralletje for the initial work for this PR!
TODO:
Pluto
object, but we could also pass it into the script directly, like we do forinvalidation
andcurrentScript
.