Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingredients List #996

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Ingredients List #996

wants to merge 7 commits into from

Conversation

aban1
Copy link

@aban1 aban1 commented Apr 12, 2023

Aiming to resolve this issue

I added ingredients as a separate piece of data for every article of food. This way one can store special information about the food and also the ingredients, rather than placing the ingredients in the notes column. I thought it was important to keep those two separate. Now there is a hover tool tip for ingredients in the order page, and in the order summary page.

Screen Shot 2023-04-12 at 4 56 03 PM
The mouse is hovering over the Pad Thai tool tip in the screenshot above (order page).

Screen Shot 2023-04-12 at 5 17 43 PM
There is a tooltip for both notes and ingredients in the order summary page above

Screen Shot 2023-04-12 at 5 19 47 PM
There is now a spot to store ingredients while creating a new article

Copy link
Contributor

@lentschi lentschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, @aban1,

however I think its important to avoid feature overload in the foodsoft to ensure future maintainability. So, reading the issue description, I can see you've already cosidered using the notes field:

the text field "Notizen/notes" which would allow 255 characters get truncated as you see in picture 1. I guess it is not an option to allow more room for this green area because it worsens the mobile use of the foodsoft.

True, but that is a mere design issue that should be fixed some time in the future upon remastering the FE design of foodsoft (Though admittedly I cannot give a time estimate for when this is going to happen.)

If however these changes are urgent for you, I'd personally favor moving them to a plugin using deface on the relevant views.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding ingredients of articles in the foodsoft order page
2 participants