Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow player to go to respective repo when clicked on logo. #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thekbbohara
Copy link

Feature #133

What does this PR do?

This PR enhances the user experience by wrapping the repository logos in anchor tags, linking to their respective GitHub repositories. This change allows users to easily navigate to the repositories directly from the player interface.

How should this be tested?

  • Test A
    -- Go to https://oss.gg/<[githubLogin]>
    -- Click on the Image/logo of any availabe organization repositories and it should take to their respective github repo.

Dependencies

No additional dependencies are required for this change.

Checklist

  • [✓] Filled out the "How to test" section in this PR
  • Read How we Code at oss.gg
  • [✓] Self-reviewed my own code
  • [✓] Commented on my code in hard-to-understand bits , its not hard to understand
  • [✓] Ran pnpm build
  • [✓] Checked for warnings, there are none
  • [✓] Removed all console.logs
  • [✓] Merged the latest changes from main onto my branch with git pull origin main
  • [✓] My changes don't cause any responsiveness issues

Copy link

vercel bot commented Oct 11, 2024

@thekbbohara is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada
Copy link
Member

good idea but doesn't work because the link needs to be this but the data currently isn't pulled accordingly:

image

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@thekbbohara
Copy link
Author

good idea but doesn't work because the link needs to be this but the data currently isn't pulled accordingly:

image

what should i do then? hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants