FIO-8819: Removed duplicate request on form manager search #1094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8819
Description
Issue: The formManager search calls
this.formGrid.pageChanged
, which internally calls therefreshGrid
method. TherefreshGrid
method makes an HTTP request to get forms. Additionally, the formManager search also callsthis.formGrid.refreshGrid
. This results in tworefreshGrid
calls and two HTTP requests with the same data. Furthermore, the variablesthis.gridQuery
andthis.formGrid.query
are equal becausethis.gridQuery
is passed as a prop tothis.formGrid
.Regarding the clearSearch method: when we manually reassign
this.gridQuery
to another object,this.gridQuery
andthis.formGrid.query
are no longer equal, so we need to reassignthis.formGrid.query
before making the API call.Solution: Remove the second
refreshGrid
call.How has this PR been tested?
Manually
Checklist: