-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hurl parser added #511
base: main
Are you sure you want to change the base?
Hurl parser added #511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add models.dart
inside src/models/
and it should export all models.
That file should be exported here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok sure will do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the source of the grammar. Provide reference to the actual library.
How was this file created? Manually done, AI generated? what resources were used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's grammar available on the Hurl.dev website. Gave that to AI and then it generated a initial code. It was not working of-course and I fixed alot of the parsers and ambiguity in the grammar.(the actual grammar has ambiguity) so that was an issue and testing out entire grammar and fixing it is the real job here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link to the official grammar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All models must used freezed with JsonSerializable options. |
Also, did you get a chance to directly integrate hurl Rust library using https://pub.dev/packages/flutter_rust_bridge? |
Nope I didn't check out that way as of now. Will check it out after I get an initial working of this current parser. |
It is recommended that you proceed in the following manner. |
It makes sense to leverage the upstream project, as it ensures we benefit directly from any updates. I'll look into flutter_rust_bridge method and drip this one for the moment.
|
PR Description
In progress hurl parser implementation
Related Issues
Checklist
main
branch before making this PRflutter upgrade
and verify)flutter test
) and all tests are passingAdded/updated tests?
We encourage you to add relevant test cases.
OS on which you have developed and tested the feature?