Update strategies doc #1485
Update strategies doc #1485
Conversation
docs/references/strategies/README.md
Outdated
|
|
||
| | Language/Package Manager | Kind of analysis | Detect Vendored Code | | ||
| |-------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------|----------------------| | ||
| | [C#](https://github.com/fossas/fossa-cli/tree/master/docs/references/strategies/languages/dotnet) | Static | ❌ | |
There was a problem hiding this comment.
[Question] Is Nuget always what's used for C#? I don't need this resolved for approval but it feels like the package manager or NuGet is the right thing to put here vs. the language.
There was a problem hiding this comment.
it's a little strange. first: no, nuget isn't the only package manager for C# or .NET generally. But inside FOSSA CLI we group all the tactics for .NET under the Nuget module, e.g. Strategy.NuGet.Paket.
i do think it probably makes more sense to refer to the package manager in this table like we do for other languages, but i didn't make that change here to minimize change/confusion.
There was a problem hiding this comment.
I've gone ahead and updated these to match the other package managers in the table: C# was the only odd one out.
There was a problem hiding this comment.
I think that looks good, thanks!
Overview
It was brought to our attention that the docs for nuget strategies were incorrect: they said the nuget strategies are dynamic but they're actually static.
This PR updates that listing and overhauls the table in an attempt to make the dynamic vs static relationship more clear. Note: I did not double check every strategy; I just went off what we currently listed in that doc.
Rendered preview here.