-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a dedicated plugin for SSO functionalities #475
Conversation
Reviewer's Guide by SourceryThis PR implements a dedicated SSO (Single Sign-On) plugin that enables social login functionality through MediaWiki, Google, and GitHub. The implementation includes a new UI for managing OAuth applications and keys, integration with Django Allauth for social authentication, and the necessary backend infrastructure to support these features. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @HungNgien - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider adding user feedback for authentication failures instead of silently redirecting to index in the CustomSocialAccountAdapter
- Add a confirmation dialog before allowing OAuth application deletion to prevent accidental removals
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Add UI for setting page of generating sso keys
Add sign-in buttons for MediaWiki, Google and Github
This PR resolves #454
Summary by Sourcery
Implement a dedicated plugin for SSO functionalities, including UI for generating SSO keys and sign-in buttons for MediaWiki, Google, and GitHub. Enhance the global settings with SSO configuration capabilities and update project dependencies to support social authentication.
New Features:
Enhancements:
Build: