Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note and link to Windows driver to readme #236

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Add note and link to Windows driver to readme #236

merged 2 commits into from
Sep 25, 2024

Conversation

marcnause
Copy link
Contributor

@marcnause marcnause commented Sep 24, 2024

Added a note for Windows users to install the appropriate driver if they use the v6 board.

Fixes #235

Summary by Sourcery

Update the README to include instructions for Windows users to install the necessary drivers for the PSLab v6 device.

Documentation:

  • Add a note to the README for Windows users to install the CP210x Windows Drivers from the Silicon Labs website when using the PSLab v6 device.

Copy link

sourcery-ai bot commented Sep 24, 2024

Reviewer's Guide by Sourcery

This pull request adds a note to the README.md file for Windows users, instructing them to install the appropriate driver for the PSLab v6 device. The change is straightforward and aims to address an issue related to device compatibility on Windows systems.

File-Level Changes

Change Details Files
Add a note about Windows driver installation for PSLab v6 device
  • Insert a new paragraph with information about the required driver
  • Include a link to the Silicon Labs website for downloading the CP210x Windows Drivers
README.md

Sequence Diagram

No sequence diagram generated.


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

@marcnause marcnause requested a review from bessman September 24, 2024 20:55
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @marcnause - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

README.md Outdated Show resolved Hide resolved
@bessman bessman merged commit 7c0153d into fossasia:development Sep 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Driver must be installed to use PSLab v6 with Python library on Windows systems
2 participants