Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to the CI and tox. #490

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

mbyrnepr2
Copy link
Contributor

@mbyrnepr2 mbyrnepr2 commented Oct 10, 2023

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #490 (404ad06) into main (717be42) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #490   +/-   ##
=====================================
  Coverage   90.4%   90.4%           
=====================================
  Files         39      39           
  Lines       1084    1084           
  Branches     220     220           
=====================================
  Hits         980     980           
  Misses        89      89           
  Partials      15      15           

@fpgmaas fpgmaas enabled auto-merge (squash) October 10, 2023 17:36
@fpgmaas
Copy link
Owner

fpgmaas commented Oct 10, 2023

@mbyrnepr2 Thanks for the contribution! It seems the deletion of the 3.12-dev CI checks is not picked up properly. Can you try this?

auto-merge was automatically disabled October 10, 2023 17:44

Head branch was pushed to by a user without write access

@fpgmaas
Copy link
Owner

fpgmaas commented Oct 11, 2023

@mbyrnepr2 Thanks for the contribution! It seems the deletion of the 3.12-dev CI checks is not picked up properly. Can you try this?

Sorry, turns out the issue was on our side; the 3.12-dev versions were required in the branch protection rules. Modified that now!

@fpgmaas fpgmaas merged commit ccb8624 into fpgmaas:main Oct 11, 2023
19 checks passed
@mbyrnepr2 mbyrnepr2 deleted the add_py_312 branch October 11, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants