Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom history manager for canvas for more control #261

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

surajshetty3416
Copy link
Member

This was done mainly to maintain the selected block states with canvasBlock snapshot so that affected block gets highlighted during undo and redo

  • Fixed a case where duplicate snapshots was getting created while creating a new block
  • This should also minimize storage required to store history snapshot by eliminating unnecessary data

surajshetty3416 and others added 4 commits December 10, 2024 10:49
- Maintain the state of selected IDs to detect which block was affected during undo
- Also, minimize storage required to store history snapshot by eliminating unnecessary data
- Avoid duplicate snapshot
- Properly pause history handler while choosing color
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.94%. Comparing base (252dc66) to head (7e1ef1b).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #261   +/-   ##
========================================
  Coverage    41.94%   41.94%           
========================================
  Files           15       15           
  Lines          906      906           
========================================
  Hits           380      380           
  Misses         526      526           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@surajshetty3416 surajshetty3416 merged commit e59711d into develop Dec 12, 2024
6 checks passed
@surajshetty3416 surajshetty3416 deleted the manually-manage-history branch December 12, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant