Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageMeta): Don't access document in top-level #207

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cogk
Copy link

@cogk cogk commented Oct 23, 2024

Improve compatibility with tools that set the document global to undefined while pre-rendering/SSR (e.g. Nitro).

https://stackoverflow.com/questions/46058544/document-is-not-defined-in-nuxt-js

Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for frappeui ready!

Name Link
🔨 Latest commit 4e55352
🔍 Latest deploy log https://app.netlify.com/sites/frappeui/deploys/6718f7c3676ad100088be50f
😎 Deploy Preview https://deploy-preview-207--frappeui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netchampfaris
Copy link
Contributor

@cogk

Hey are you able to use frappe-ui in a nuxt project with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants