Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove custom list view #2111

Merged
merged 14 commits into from
Dec 23, 2024
Merged

refactor: remove custom list view #2111

merged 14 commits into from
Dec 23, 2024

Conversation

RitvikSardana
Copy link
Member

@RitvikSardana RitvikSardana commented Dec 23, 2024 •
edited
Loading

What Changed?

  1. Knowledge Base was using custom ListVIew components which was creating 25 Api calls per page.
    refactored it with the ListViewBuilder component.

  2. Refactored Notifications Panel.

  3. Added TS Config to include Vue Files.

  4. Removed:

    1. Custom List View Component.
    1. List Manager (composable for managing resources).
    1. Functions and files relevant to the listManager.
    1. Removed Escalation Rules page from routing.

Continuation of PR: #2063

@RitvikSardana RitvikSardana changed the title refactor: remove custom list view from knowledge base refactor: remove custom list view Dec 23, 2024
@RitvikSardana RitvikSardana merged commit 98c3335 into frappe:develop Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RitvikSardana