Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: method name and company wise filter in accouts field #206

Merged

Conversation

Nihantra-Patel
Copy link
Member

@Nihantra-Patel Nihantra-Patel commented Oct 10, 2024

Change create_loan_security_assignment_from_loan_application to create_loan_security_assignment.

In other test cases, create_loan_security_assignment_from_loan_application is used, while sometimes create_loan_security_assignment is used. Please update all instances to use the correct name.

Additionally, set a company-wise filter for the loan product.

@deepeshgarg007
Copy link
Member

@Nihantra-Patel create_loan_security_assignment is the correct method, replace every method with this

@deepeshgarg007 deepeshgarg007 merged commit a548d58 into frappe:poc-staging Oct 23, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants