Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add required indicator in jobs and quiz #1108

Merged
merged 3 commits into from
Nov 27, 2024
Merged

feat: add required indicator in jobs and quiz #1108

merged 3 commits into from
Nov 27, 2024

Conversation

iamejaaz
Copy link
Contributor

@iamejaaz iamejaaz commented Nov 8, 2024

Reason of PR

  • Add the required indicator to the Jobs and Quiz forms for fields that are missing.

Screenshot

image

@cypress Cypress
Copy link

cypress bot commented Nov 8, 2024 •
edited
Loading

lms    Run #831

Run Properties:  status check passed Passed #831  •  git commit 1c7869511e ℹ️: Merge 8e1db293dbda2e8f2db27db4a7d9fe8da6584595 into b1a0556c1299384bb537614445d2...
Project lms
Branch Review required-indicator-job
Run status status check passed Passed #831
Run duration 00m 35s
Commit git commit 1c7869511e ℹ️: Merge 8e1db293dbda2e8f2db27db4a7d9fe8da6584595 into b1a0556c1299384bb537614445d2...
Committer Ejaaz Khan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@iamejaaz iamejaaz requested a review from pateljannat November 18, 2024 18:00
@iamejaaz iamejaaz requested a review from pateljannat November 19, 2024 18:24
@pateljannat pateljannat merged commit 6329d9c into frappe:develop Nov 27, 2024
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pateljannat pateljannat Awaiting requested review from pateljannat

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamejaaz @frappe-pr-bot @pateljannat