perf: prevent caches from frappe.clear_cache #2373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
force-pushed
the
perf/cache_rename
branch
from
d260ca3 to
c4d029d
Compare
Press is single-deploy, so this is fine. It's almost equivalent to frappe.clear_cache()
ankush
force-pushed
the
perf/cache_rename
branch
from
c4d029d to
f55c7bc
Compare
ankush
commented
Dec 18, 2024
| # - Use frappe.cache.flushall() instead. | ||
| persistent_cache_keys = [ | ||
| *__persistent_cache_keys, | ||
| "agent_job_step_output", |
There was a problem hiding this comment.
This one isn't evicted anywhere btw, it can get huge but we have tons of memory so 🤷
This was referenced Dec 23, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because sites are renamed and rename can't reliably guess what
else got modified via queries so it just drops everything.
AFAIK, new sites are renamed so they don't have anything else linking to them.
So it's fine to just... ignore it.
Risks:
frappe.clear_cache()can break, usefrappe.cache.flushall()I also identified bunch of keys that need to be "persistent", added them all to separate list.