Suggested fix for issue #3 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I mentioned in my comment on issue #2 , there is no need for the changes you made in this PR. It is important to know that peer-upnp is only responsible for requests starting with "/upnp". All other requests need to be handled in your application (e.g. upnp-test.js). This allows you to reuse the server for other purposes and not only for peer-upnp. I hope the example makes my explanation more clear. If this solves you issue I will reject your PR and close the issue. |
…me does not start with peer.prefix is not handled, i.e. no response is generated for this case.
…l.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case." This reverts commit a7e7819.
…where url.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case."" This reverts commit f821f9c.
…aunhoferfokus#2"" This reverts commit cf8c4f9.
… peer-ssdp issue fraunhoferfokus#3: addMembership EADDRNOTAVAIL revisited -
* Changes: * Update to peer-ssdp version 0.0.5
fixed checking of path to identify peer requests
xmlns for response now includes the full namespace with schema, service, type and version
…se-xmlns Fix setting xml namespace for responses
…me does not start with peer.prefix is not handled, i.e. no response is generated for this case.
…l.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case." This reverts commit a7e7819.
…where url.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case."" This reverts commit f821f9c.
…aunhoferfokus#2"" This reverts commit cf8c4f9.
… peer-ssdp issue fraunhoferfokus#3: addMembership EADDRNOTAVAIL revisited -
# Conflicts: # lib/peer-upnp.js
(cherry picked from commit 6236fa6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3 - The case where url.pathname does not start with peer.prefix is not handled, i.e. no response is generated for this case.