feat: Docker development environment #1337
Conversation
| @@ -12,7 +12,8 @@ Want to contribute? Great. Please review the following guidelines carefully and | |||
| 6. [Updating existing documentations](#updating-existing-documentations) | |||
| 7. [Other contributions](#other-contributions) | |||
| 8. [Coding conventions](#coding-conventions) | |||
| 9. [Questions?](#questions) | |||
| 9. [Developing in Docker](#developing-in-docker) | |||
There was a problem hiding this comment.
The section is missing in the file (has not been committed)?
.env
Outdated
| @@ -0,0 +1,2 @@ | |||
| USER_ID=1000 | |||
| GROUP_ID=1000 | |||
There was a problem hiding this comment.
Maybe include a comment # for Dockerfile-dev?
docker-compose.yml
Outdated
| @@ -0,0 +1,13 @@ | |||
| version: '3.7' | |||
There was a problem hiding this comment.
Since we already have two Dockerfiles for running devdocs in production, I would not expect docker-compose.yml to be meant for development only.
| # a temporary directory to hold the lock files while the gems are installed. | ||
| WORKDIR /devdocs/ | ||
|
|
||
| COPY Gemfile Gemfile.lock Rakefile /devdocs/ |
There was a problem hiding this comment.
Running docker build - < Dockerfile-dev failed:
Step 9/14 : COPY Gemfile Gemfile.lock Rakefile /devdocs/
COPY failed: stat /var/lib/docker/tmp/docker-builder202400793/Gemfile: no such file or directory
(Not exactly sure how it is meant to be used, though…)
Co-authored-by: Simon Legner <[email protected]>
Co-authored-by: Simon Legner <[email protected]>
|
Thanks for the review, Simon. The latest commits should have addressed all your concerns - including adding the missing docs (thanks reflog 😓). I also moved the environment variables into a sample.env, because I never should have added .env to git! |
|
Hey @simon04, I'm still working on this. Right now using |
|
@ojeytonwilliams and @simon04 Any updates on this? I can pick this up if you'd like. I cloned the repo and started making a devcontainer... and then realized you guys already started! |
This should make it a little easier to get started as a new contributor, as well as cut out 'works on my machine' bugs.
@freeCodeCamp/devdocs let me know what you think. Does this all work as you expect?