Clone error with all constructor parameters

fullstack-build · Apr 12, 2023 · 0e751a5 · mustard-mh · Aug 4, 2023 · 0e751a5
1 parent 28ef27a
commit 0e751a5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/examples/nodejs/index2.ts b/examples/nodejs/index2.ts
@@ -109,3 +109,13 @@ const e = createReadonlyError("message", "property");
 logger.error(e);
 
 ///////////////////////////
+
+class CustomError extends Error {
+  constructor(message1: string, message2: string) {
+    super(message1);
+    console.log("***", message1, message2);
+  }
+}
+
+const err = new CustomError("a", "b");
+logger.error(err);
diff --git a/src/BaseLogger.ts b/src/BaseLogger.ts
@@ -276,11 +276,14 @@ export class BaseLogger<LogObj> {
   }
 
   private _cloneError<T extends Error>(error: T): T {
-    const ErrorConstructor = error.constructor as new (message?: string) => T;
-    const newError = new ErrorConstructor(error.message);
+    const ErrorConstructor = error.constructor as new (...args: any[]) => T;
+    const errorProperties = Object.getOwnPropertyNames(error);
+    const errorArgs = errorProperties.map((propName) => error[propName]);
+
+    const newError = new ErrorConstructor(...errorArgs);
     Object.assign(newError, error);
-    const propertyNames = Object.getOwnPropertyNames(newError);
-    for (const propName of propertyNames) {
+
+    for (const propName of errorProperties) {
       const propDesc = Object.getOwnPropertyDescriptor(newError, propName);
       if (propDesc) {
         propDesc.writable = true;