-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for HTTPS_PROXY #306
base: master
Are you sure you want to change the base?
Conversation
This commit adds support for the HTTPS_PROXY environment variable. At the moment the NO_PROXY environment variable is ignored, please be aware of that! This should close fullstorydev#166
Thanks a lot for the PR! |
Hi @denysvitali thanks for the contribution. Is there a reason we'd need a new third party lib instead of using Go's native proxying? |
can confirm this is working great for us - would love to see it merged 👍 |
https://github.com/mwitkow/go-http-dialer README explains it:
net/proxy cannot be used here AFAIK because you can't have a dialer that uses TCP over HTTP. The only way to do it is to use a SOCKS5 proxy. |
I think I'd be trivially fine with a patch to just change |
Release with this patch: https://github.com/L11R/grpcurl/releases/tag/v1.8.8 |
Hi, what exactly is the status of this patch? So was this patch not carried forward, or did it somehow change and require different configuration? (Incidentally, the patch in 1.8.8 did not work on Windows) |
This commit adds support for the
HTTPS_PROXY
environment variable.At the moment the
NO_PROXY
environment variable is ignored, pleasebe aware of that!
This should close #166
On top of that, this adds support for
SOCKS_PROXY
via the ProxyFromEnvironment method ofgolang.org/x/net/proxy