Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

Commit

Permalink
Allow system principal and "modify request"-hooked by default
Browse files Browse the repository at this point in the history
Since having them disabled breaks not only addons but even some of firefox
features.

This was the behavior before introduction of "http-on-modify-request" hook
anyway.

close #148
  • Loading branch information
futpib committed Jan 17, 2015
1 parent 89284db commit 9703b83
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 15 deletions.
15 changes: 0 additions & 15 deletions src/defaults/rulesets/compatibility.ruleset
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,3 @@ rules:
# like magnet, irc, webcal, custombutton, etc
# by allowing any documents from such schemes.
[contentType] DOCUMENT: ACCEPT

* -> *:
# Allows requests having system principal
# TODO A lot of addons seem to be using nsIHTTPChannel and for now this is
# the most obvious way not to break them. But this also allows favicon and
# google safebrowsing (and maybe more) requests that may be unwanted by
# user. This is hopefully a temporary solution until a good way of dealing
# with such requests is developed
[specialPrincipal] system: ACCEPT

* -> *:
# Allows requests hooked by "http-on-modify-request" observer
# TODO Highly related to the above todo, this effectively makes the observer
# hook useless. Temporary solution, hopefully.
[hook] modifyRequest: ACCEPT
15 changes: 15 additions & 0 deletions src/defaults/rulesets/default.ruleset
Original file line number Diff line number Diff line change
Expand Up @@ -40,3 +40,18 @@ rules:
(web|file) -> internal:
# top-level media player and image viewer require internal styles
[contentType] STYLESHEET: ACCEPT

* -> *:
# Allows requests having system principal
# TODO A lot of addons seem to be using nsIHTTPChannel and for now this is
# the most obvious way not to break them. But this also allows favicon and
# google safebrowsing (and maybe more) requests that may be unwanted by
# user. This is hopefully a temporary solution until a good way of dealing
# with such requests is developed
[specialPrincipal] system: ACCEPT

* -> *:
# Allows requests hooked by "http-on-modify-request" observer
# TODO Highly related to the above todo, this effectively makes the observer
# hook useless (except for requests mangled by lib/request-info).
[hook] modifyRequest: ACCEPT

0 comments on commit 9703b83

Please sign in to comment.