Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

chore: mark mantle and mantle sepolia chains as supporting eip 1559 #2810

Closed
wants to merge 1 commit into from

Conversation

luzzif
Copy link
Contributor

@luzzif luzzif commented Sep 6, 2024

Motivation

Mantle and Mantle Sepolia support EIP 1559. As proof, we can see that by doing:

// for mantle
curl -X POST --data '{"jsonrpc":"2.0","method":"eth_getBlockByNumber","params":["latest", false],"id":1}' https://rpc.mantle.xyz

// for mantle sepolia
curl -X POST --data '{"jsonrpc":"2.0","method":"eth_getBlockByNumber","params":["latest", false],"id":1}' https://rpc.sepolia.mantle.xyz

the returned block object contains the baseFeePerGas attribute.

Solution

I just updated the is_legacy function by moving Mantle and MantleSepolia to the false arm.

P.S.: I have a Rust program posting transactions to Mantle Sepolia and all of them are currently failing at the fill_transaction stage. Is there any workaround I can use while this is being reviewed and released?

@mattsse
Copy link
Collaborator

mattsse commented Sep 6, 2024

can you please apply the changes to https://github.com/alloy-rs/chains instead

@luzzif
Copy link
Contributor Author

luzzif commented Sep 6, 2024

I can do that too, but in my project I'm still using Ethers. Has Ethers been completely deprecated in favor of alloy?

Edit: The configuration is already correct in alloy

@luzzif luzzif closed this Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants