Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 952 operational dispatch class #960

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sylvaincormier
Copy link

This PR addresses the changes discussed in #952, introducing operational dispatch classes for the specified extrinsics:

pallet_transaction_pause::pause_transaction
pallet_omnipool::set_asset_tradable_state
pallet_stableswap::set_asset_tradable_state

As requested, I’ve ensured these critical calls are now dispatched with operational priority, allowing them to ignore block weight limits. Following your guidance, I’ve checked for potential side effects and confirmed that the operational class integration behaves as intended.

To validate these modifications, I ran a series of integration tests, including:

send_operational_extrinsic.sh
send_asset_tradable_operational.sh
send_many_normal_txs.sh
query_asset_state.sh

All tests passed successfully, as shown in the attached screenshot. The results indicate that the operational dispatch works as expected and doesn’t introduce unintended behavior.

Please let me know if you have any further feedback or if there are additional changes you’d like to see.
I appreciate your time reviewing this contribution and look forward to your input.
Screenshot 2024-12-10 at 5 55 08 PM

…ls (galacticcouncil#952)

This commit changes the dispatch class to operational for critical transactions across:
- `pallet_transaction_pause::pause_transaction`
- `pallet_omnipool::set_asset_tradable_state`
- `pallet_stableswap::set_asset_tradable_state`

This ensures these important extrinsics can bypass block weight limits and be executed promptly.

Additionally, operational-class tests have been introduced to verify behavior both under normal and operational conditions. The new integration tests cover scenarios to ensure that these calls function as intended, providing better resiliency and control over the execution of critical operations.
@sylvaincormier sylvaincormier force-pushed the issue-952-operational-dispatch-class branch from d2a6815 to 65b6d48 Compare December 10, 2024 23:15
@sylvaincormier sylvaincormier marked this pull request as draft December 10, 2024 23:31
@sylvaincormier sylvaincormier marked this pull request as ready for review December 17, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant