feat(assert): store original message in AssertionError
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks perfect Can you fix the conflict? |
`AssertionError` wraps the message provided during instantiation with some additional text:
```ts
const error = new AssertionError("message");
console.log(error.message); // 'Wrong assertion encountered: "message"'
```
This helpfully communicates that the error resulted from a failed assertion.
Sometimes we want to access the original message without the wrapper text. For example, we may wish to surface the error directly to a user.
This change adds an `originalMessage` property to `AssertionError` to store the original message without any wrapper text.
The existing behaviour is unchanged, but library consumers now have access to the original message.
Closes garronej#35
psychedelicious
force-pushed
the
psyche/feat/original-message
branch
from
1817ed7 to
538da12
Compare
|
Thanks! Fixed the conflict. |
|
Thank you! I have released a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssertionErrorwraps the message provided during instantiation with some additional text:This helpfully communicates that the error resulted from a failed assertion.
Sometimes we want to access the original message without the wrapper text. For example, we may wish to surface the error directly to a user.
This change adds an
originalMessageproperty toAssertionErrorto store the original message without any wrapper text.The existing behaviour is unchanged, but library consumers now have access to the original message.
Closes #35