Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS message parsing operation #1826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hunts
Copy link

@hunts hunts commented Jun 7, 2024

This is useful for debugging DNS related issues when the input is a wireformat binary of a DNS message.

Example:

  • Input: q80BAAABAAAAAAAAA3d3dwdleGFtcGxlA2NvbQAAAQAB
  • Operations: From Base64 -> Parse DNS Message
  • Output:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 43981
;; flags: rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;www.example.com.		IN	A

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2024

CLA assistant check
All committers have signed the CLA.

@hunts
Copy link
Author

hunts commented Jun 7, 2024

This should cover decoding part of #940.

@hunts hunts force-pushed the dns-message-parsing branch from cb1fb68 to d8bcf5d Compare June 7, 2024 18:28
@hunts
Copy link
Author

hunts commented Jun 8, 2024

The UI Tests failure looks like unrelated to my changes?

@a3957273
Copy link
Member

Hey @hunts, would you be able to resolve the conflicts with main? That should fix your test issues as well.

@hunts hunts force-pushed the dns-message-parsing branch 2 times, most recently from f1d352d to 29581c3 Compare June 13, 2024 05:47
@hunts
Copy link
Author

hunts commented Jun 13, 2024

Hey @hunts, would you be able to resolve the conflicts with main? That should fix your test issues as well.

Rebased. But looks like there is still an unrelated UI test failure, same with main branch.

Example:

- Input: `q80BAAABAAAAAAAAA3d3dwdleGFtcGxlA2NvbQAAAQAB`
- Operations: `From Base64` -> `Parse DNS Message`
- Output:
```
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 43981
;; flags: rd; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0

;; QUESTION SECTION:
;www.example.com.		IN	A
```
@hunts hunts force-pushed the dns-message-parsing branch from 29581c3 to 462cda7 Compare June 18, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants