fix backoff time

gdgbari · Oct 17, 2024 · 77f5db7 · 77f5db7
1 parent a445eac
commit 77f5db7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/functions/src/functions/quiz.ts b/functions/src/functions/quiz.ts
@@ -11,8 +11,11 @@ import { parseGroupRef, parseQuestionListRef } from "../utils/firestoreHelpers";
 import { serializedErrorResponse, serializedExceptionResponse, serializedSuccessResponse } from "../utils/responseHelper";
 import { generateUniqueRandomStrings } from "../utils/stringHelpers";
 
+const timePerQuestion = 60 * 1000;
+const backoffTime = 30 * 1000;
+
 export const createQuiz = functions.https.onCall(async (data, context) => {
-    const { questionList, type, talkId, sponsorId, title, isOpen } = data;
+    const { questionList, type, title, isOpen } = data;
 
     if (!context.auth) {
         return serializedErrorResponse("unauthenticated", "User must be authenticated.");
@@ -69,12 +72,10 @@ export const createQuiz = functions.https.onCall(async (data, context) => {
         const quizDoc = await quizRef.add({
             questionList: questionListRef,
             type: type,
-            talkId: talkId ?? "",
-            sponsorId: sponsorId ?? "",
             title: title ?? "",
             maxScore: maxScore,
             isOpen: isOpen ?? false,
-            timerDuration: 1000 * 60 * 3, // 3 minutes
+            timerDuration: timePerQuestion * questionList.length,
             creatorUid: context.auth.uid,
         });
 
@@ -263,10 +264,9 @@ export const submitQuiz = functions.https.onCall(async (data, context) => {
         }
 
         if (
-            startTimeData.startTimestamp + quizData.timerDuration - 10000 <
+            startTimeData.startTimestamp + quizData.timerDuration - backoffTime <
             Date.now()
         ) {
-            // 10 seconds buffer for network latency
             return serializedErrorResponse("quiz-time-up", "Quiz time is up.");
         }
 

diff --git a/lib/data/models/quiz.dart b/lib/data/models/quiz.dart
@@ -36,10 +36,6 @@ class Quiz extends Equatable {
   }
 
   factory Quiz.fromMap(Map<String, dynamic> map) {
-    const backOffTime = 30000;
-    final timerDuration = map['timerDuration'] != null
-        ? (map['timerDuration'] as int) - backOffTime
-        : 0;
     return Quiz(
       quizId: map['quizId'] as String? ?? '',
       title: map['title'] as String? ?? '',
@@ -49,7 +45,9 @@ class Quiz extends Equatable {
           map['questionList'] ?? [],
         ).map((x) => Question.fromMap(x)),
       ),
-      timerDuration: Duration(milliseconds: timerDuration),
+      timerDuration: Duration(
+        milliseconds: (map['timerDuration'] as int?) ?? 0,
+      ),
     );
   }