Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly estimate row heights in sequence table #4393

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Correctly estimate row heights in sequence table #4393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a83f7f8
correctly estimate row heights in sequence table
rpiaggio Dec 17, 2024
564a7c6
fix header height
rpiaggio Dec 17, 2024
58c2ec4
row heights in lucuma-ui
rpiaggio Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion explore/src/main/scala/explore/config/sequence/GmosSequenceTable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,12 @@ private sealed trait GmosSequenceTableBuilder[S, D: Eq] extends SequenceRowBuild

PrimeAutoHeightVirtualizedTable(
table,
estimateSize = _ => 25.toPx,
estimateSize = index =>
table.getRowModel().rows.get(index).map(_.original.value) match
case Some(Right(SequenceIndexedRow(SequenceRow.Executed.ExecutedStep(_, _), _))) =>
SequenceRowHeight.WithExtra
case _ =>
SequenceRowHeight.Regular,
overscan = 8,
containerRef = resize.ref,
compact = Compact.Very,
Expand Down
22 changes: 12 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@opentelemetry/auto-instrumentations-web": "^0.44.0",
"@react-hook/size": "^2.1.2",
"@tanstack/react-table": "^8.20.5",
"@tanstack/react-virtual": "v3.10.9",
"@tanstack/react-virtual": "v3.11.2",
"highcharts": "11.4.8",
"loglevel": "1.9.2",
"primeicons": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion project/Versions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ object Versions {
val lucumaSchemas = "0.110.0"
val lucumaOdbSchema = "0.17.1"
val lucumaSSO = "0.7.1"
val lucumaUI = "0.124.5"
val lucumaUI = "0.124.6"
val monocle = "3.3.0"
val mouse = "1.3.2"
val mUnit = "1.0.3"
Expand Down
Loading