Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show executing step in visit, show all nextAtom steps #4396

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

rpiaggio
Copy link
Contributor

The currently executing step is not shown anymore as part of the visit, but instead as it comes in nextAtom. This avoids showing dataset info until it completes.

Also, a bug is fixed where some steps were hidden from nextAtom in cases where it contained more than 2 steps and it was currently executing the 2nd or later step.

@mergify mergify bot added the explore label Dec 17, 2024
@rpiaggio
Copy link
Contributor Author

@rpiaggio rpiaggio changed the title Don't show executing step in visit, show all nextAtom Don't show executing step in visit, show all nextAtom steps Dec 17, 2024
Copy link

bundlemon bot commented Dec 17, 2024

BundleMon

Files updated (1)
Status Path Size Limits
index-(hash).js
1.71MB (+786B +0.04%) -
Unchanged files (7)
Status Path Size Limits
exploreworkers-(hash).js
594.61KB -
index-(hash).css
66.06KB -
workbox-window.prod.es5-(hash).js
2.07KB -
catalogworker-(hash).js
90B -
plotworker-(hash).js
88B -
agsworker-(hash).js
87B -
itcworker-(hash).js
87B -

Total files change +786B +0.03%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpiaggio rpiaggio merged commit efe56f4 into master Dec 17, 2024
16 checks passed
@rpiaggio rpiaggio deleted the sc-4319-explore-shows-file-names-before-execution branch December 17, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants