Use a ref for TargetName input instead of direct dom lookup #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddburnside
commented
Dec 18, 2024
| (_, inputRef) => | ||
| inputRef.get | ||
| .flatMap( | ||
| _.foldMap(i => Callback(timers.setTimeout(50)(i.select()))) |
There was a problem hiding this comment.
With a timeout of zero, this solution had about the same reliability as the previous one. That is to say, the input always got selected but sometimes the cursor was at the end of the field rather than selecting all of the text. With the 50ms delay it has worked every time I tried it.
There was a problem hiding this comment.
Can this be done as Callback.delayMs(50)?
There was a problem hiding this comment.
I'm not sure. delayMs returns an AsyncCallback which seemed harder to deal with. I'd have to turn it back into a Callback.
BundleMonFiles updated (1)
Unchanged files (7)
Total files change +1.38KB +0.06% Final result: ✅ View report in BundleMon website ➡️ |
toddburnside
force-pushed
the
targetname-ref
branch
from
f1c8ec9 to
ecb9eda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on an intractable story, I saw this comment and thought "hey, here's something I can atually fix!"