Add a word counter for abstract and indicate if the abstract is too long #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cquiroz
commented
Dec 19, 2024
cquiroz
commented
BundleMonFiles updated (2)
Unchanged files (6)
Total files change +762B +0.03% Final result: ✅ View report in BundleMon website ➡️ |
rpiaggio
reviewed
Dec 19, 2024
| @@ -2014,6 +2014,11 @@ svg.fa-triangle-exclamation.explore-error-icon { | |||
| // ------ | |||
| // Proposals and Partner Splits | |||
| // ------ | |||
|
|
|||
| .explore-abstract-too-long { | |||
| color: var(--error-background-color); | |||
There was a problem hiding this comment.
There's a recently added --negative-row-color that you may want to use here instead of using a background color for the text. (There's also a --negative-row-background)
There was a problem hiding this comment.
I tried but couldn't find the new variable even after a rebase
There was a problem hiding this comment.
I tried but couldn't find the new variable even after a rebase
It's defined in lucuma-ui since it's shared with observe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.