Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monadic hook migration #4425

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Monadic hook migration #4425

merged 3 commits into from
Dec 23, 2024

Conversation

rpiaggio
Copy link
Contributor

No description provided.

@rpiaggio
Copy link
Contributor Author

Just a couple of components were migrated. They serve as template for others.

@mergify mergify bot added the explore label Dec 23, 2024
cquiroz
cquiroz approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bundlemon BundleMon
Copy link

bundlemon bot commented Dec 23, 2024

BundleMon

Files updated (2)
Status Path Size Limits
✅ exploreworkers-(hash).js
 598.51KB (+3.73KB +0.63%) -
✅ index-(hash).js
 1.71MB (+756B +0.04%) -
Unchanged files (6)
Status Path Size Limits
✅ index-(hash).css
 66KB -
✅ workbox-window.prod.es5-(hash).js
 2.07KB -
✅ catalogworker-(hash).js
 91B -
✅ agsworker-(hash).js
 85B -
✅ itcworker-(hash).js
 81B -
✅ plotworker-(hash).js
 79B -

Total files change +4.47KB +0.19%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@rpiaggio rpiaggio merged commit 3045a42 into master Dec 23, 2024
16 checks passed
@rpiaggio rpiaggio deleted the monadic-hooks branch December 23, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
explore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpiaggio @cquiroz