Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to sort by duration and start time #623

Merged
merged 5 commits into from
Dec 17, 2024
Merged

feat: add ability to sort by duration and start time #623

merged 5 commits into from
Dec 17, 2024

Conversation

shadowusr
Copy link
Member

@shadowusr shadowusr commented Dec 9, 2024 •
edited
Loading

KuznetsovRoman
KuznetsovRoman reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@KuznetsovRoman KuznetsovRoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see a reason why "sortTreeNodes" function is not tested
Could you please write corresponding unit tests for the function?

Also i suggest to not use "undefined" manually, and use typeof ... == "number" or _.isNumber. Lets leave "undefined" to js itself

lib/static/new-ui/components/MetaInfo/index.tsx Show resolved Hide resolved
lib/static/new-ui/features/suites/components/SuitesTreeView/utils.ts Outdated Show resolved Hide resolved
lib/static/new-ui/features/suites/components/SuitesTreeView/utils.ts Outdated Show resolved Hide resolved
lib/static/new-ui/features/suites/components/SuitesTreeView/utils.ts Outdated Show resolved Hide resolved
lib/static/new-ui/features/suites/components/SuitesTreeView/utils.ts Outdated Show resolved Hide resolved
lib/static/new-ui/features/suites/components/SuitesTreeView/utils.ts Outdated Show resolved Hide resolved
DudaGod
DudaGod approved these changes Dec 16, 2024
View reviewed changes
lib/adapters/test-result/testplane.ts Show resolved Hide resolved
test/unit/lib/static/utils.tsx Outdated Show resolved Hide resolved
test/unit/lib/static/utils.tsx Outdated Show resolved Hide resolved
test/unit/lib/static/utils.tsx Outdated Show resolved Hide resolved
test/unit/lib/static/utils.tsx Outdated Show resolved Hide resolved
test/unit/lib/static/components/modals/screenshot-accepter/index.jsx Outdated Show resolved Hide resolved
@shadowusr shadowusr merged commit f1a7b7e into master Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KuznetsovRoman KuznetsovRoman KuznetsovRoman left review comments

@DudaGod DudaGod DudaGod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shadowusr @DudaGod @KuznetsovRoman