Add home sale forecast usecase into documentation #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xzdandy
commented
Sep 16, 2023
•
xzdandy
commented
- Add home sale forecast use case into documentation
gaurav274
reviewed
Sep 16, 2023
gaurav274
reviewed
Sep 16, 2023
| ID 'propertytype' | ||
| FREQUENCY 'W'; | ||
|
|
||
| While running this query, EvaDB will train different models respectively for different property types (i.e., house, unit). Here is the query's output ``DataFrame``: |
There was a problem hiding this comment.
I don't understand this sentence.
There was a problem hiding this comment.
The idea is house and unit have very different prices. So we need to train different model for them. The ID column is similar to the GROUP BY. How do you think we should rephrase the sentence?
There was a problem hiding this comment.
You can add this clarification. My confusion was that we are creating a single function but you mention multiple models.
There was a problem hiding this comment.
Rephrased. Please check if it is easier to understand now.
gaurav274
reviewed
Sep 16, 2023
gaurav274
reviewed
Sep 16, 2023
gaurav274
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.