Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chatgpt exact cache #1203

Merged
merged 9 commits into from
Sep 25, 2023
Merged

fix: chatgpt exact cache #1203

merged 9 commits into from
Sep 25, 2023

Conversation

jiashenC
Copy link
Member

No description provided.

@jiashenC jiashenC self-assigned this Sep 24, 2023
@jiashenC jiashenC added the Optimizations Features/Bugs related to optimizations label Sep 24, 2023
@jiashenC jiashenC added this to the Long Term Goal milestone Sep 24, 2023
@xzdandy xzdandy modified the milestones: Long Term Goal, v0.3.7 Sep 24, 2023
@xzdandy xzdandy linked an issue Sep 24, 2023 that may be closed by this pull request
Exact caching for ChatGPT is not enabled #1195
Closed
2 tasks
@jiashenC jiashenC requested a review from xzdandy September 24, 2023 15:31
xzdandy
xzdandy approved these changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. There are conflict between staging to be fixed.

Leave some comments about making the code more modularity. Please check whether they make sense. If so and we do not want to include in this PR, please create an issue for records.

@xzdandy xzdandy merged commit c87f7c7 into staging Sep 25, 2023
@xzdandy xzdandy deleted the chatgpt-exact-cache branch September 25, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzdandy xzdandy xzdandy approved these changes

@gaurav274 gaurav274 Awaiting requested review from gaurav274

Assignees

@jiashenC jiashenC

Labels
Optimizations Features/Bugs related to optimizations
Projects
None yet
Milestone
v0.3.7
Development

Successfully merging this pull request may close these issues.

Exact caching for ChatGPT is not enabled
3 participants
@jiashenC @xzdandy @gaurav274