vcpkg #81
Draft
vcpkg #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded: |
|
This is really old, but just to leave a trail of breadcrumbs... This PR doesn't represent work that I was bottom lining, I was just trying to take the work from #79 and get CI to pass. #79 stalled out with this comment: #79 (comment) |
|
If there really is no way of getting the version from vcpkg, the version is available at runtime. This is obviously not ideal, but it would be feasible to have a Windows-only runtime version compatibility check to guard against instances in which the compile step is successful using an unsupported library version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a dupe of #79, but trying to work around whatever bug is breaking CI.
(my theory is that we won't encounter the bug when bors is running off a branch local to this repo... we'll see)