Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build GeoScript with JDK 17 #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

hungd11
Copy link

@hungd11 hungd11 commented Apr 19, 2024

JDK 17 has been out for several years. GeoScript should be made compatible with JDK 17 for increased availability across applications.

Detailed changes:

  • Geoscript fails at runtime when used in Java 17 due to using the size parameter directly in the Color class. JDK 17 restricts usage of internal parameters to a greater degree. I've updated geoscript to build with JDK 17 and fixed the corresponding issue.
  • Furthermore, Geoscript relies on some sun packages that are no longer exposed by default in JDK 17, so I had to manually expose those in the compile step as well.

@BrandonReuter
Copy link

Hi @jericks, not sure if you're still active so excuse the ping. This PR would be very useful for users to move to more modern JDKs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants