add higher-level db migration tests #1252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I have a few different questions, but overall this definitely looks like it's heading in the right direction to me. I like the assertion functions in utils.js, and I like the looks of the actual tests (20241008-01-add-user_preferences.spec.js). If we could get our migration tests looking like that going forward, that'd be a big improvement. 👍
added 14 commits
November 13, 2024 05:26
added 16 commits
November 20, 2024 05:59
This reverts commit e746eae.
alxndrsn
changed the title
matthew-white
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
.eslintrcrulesFollow-up
describeMigration.only()assertColumnExists()