Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change analytics queries to run sequentially #1344

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Dec 12, 2024

Closes #1228

Makes use of runSequentially instead of Promise.all() to do multiple database queries for computing usage metrics.

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite requested a review from sadiqkhoja December 12, 2024 00:25
@ktuite ktuite mentioned this pull request Dec 12, 2024
2 tasks
@matthew-white
Copy link
Member

I'll let @sadiqkhoja do the review, but I had just one thought. Are we able to remove lines like this from tests of analytics now?

require('events').EventEmitter.defaultMaxListeners = 30;

@ktuite ktuite merged commit c44a48f into master Dec 12, 2024
11 checks passed
@ktuite ktuite deleted the ktuite/analyticsQueries branch December 12, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query fewer analytics at once
3 participants