Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx-tests: remove unnecessary res.ok assertions #740

Merged

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Oct 6, 2024

These assertions are followed by more specific assertions on res.status, which provide more helpful error messages on failure.

These assertions are followed by more specific assertions on res.status, which provide more helpful error messages on failure.
@alxndrsn alxndrsn marked this pull request as ready for review October 6, 2024 07:35
@alxndrsn alxndrsn requested a review from lognaturel October 6, 2024 07:35
@alxndrsn alxndrsn merged commit 75e894d into getodk:master Oct 7, 2024
2 checks passed
@alxndrsn alxndrsn deleted the nginx-tests-remove-extra-res-ok-tests branch October 7, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants