Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sentry/backup.json to gitignore #3450

Merged
merged 1 commit into from
Nov 29, 2024
Merged

add sentry/backup.json to gitignore #3450

merged 1 commit into from
Nov 29, 2024

Conversation

niklassc7
Copy link
Contributor

@niklassc7 niklassc7 commented Nov 29, 2024

The backup-method described in the documentation ./scripts/backup.sh creates a backup file at sentry/backup.json which should be ignored by git.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aldy505 aldy505 requested a review from BYK November 29, 2024 08:17
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, cannot belive we didn't have this until now. Thank you so much! :)

@BYK BYK enabled auto-merge (squash) November 29, 2024 09:42
@BYK BYK disabled auto-merge November 29, 2024 09:42
@BYK BYK enabled auto-merge (squash) November 29, 2024 09:42
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (817fde2) to head (e5f4ec6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3450   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK merged commit bc0816c into getsentry:master Nov 29, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants