Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sentry web api #2489

Open
wants to merge 50 commits into
base: feat/js-sdk-integration
Choose a base branch
from
Open

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Dec 12, 2024

Description

Allows type safe API access to underlying JS SDK

In this PR only init and close is implemented, more will follow in the next PR

The creating of the binding and the initialization is gated / opt-in through the enableSentryJs flag`

💡 Motivation and Context

PR #2 of JS SDK Integration

💚 How did you test it?

Unit test, Integration Test, Manual Test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Sending envelope

#skip-changelog

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8815b03

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.90%. Comparing base (be08651) to head (8815b03).
Report is 69 commits behind head on feat/js-sdk-integration.

Files with missing lines Patch % Lines
dart/lib/src/platform_checker.dart 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/js-sdk-integration    #2489       +/-   ##
============================================================
+ Coverage                    70.98%   86.90%   +15.92%     
============================================================
  Files                           17      265      +248     
  Lines                          579     9418     +8839     
============================================================
+ Hits                           411     8185     +7774     
- Misses                         168     1233     +1065     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor changed the title update feat: sentry web api Dec 12, 2024
Copy link
Contributor

github-actions bot commented Dec 12, 2024

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/screenshot/recorder.dart
  • flutter/lib/src/screenshot/widget_filter.dart

@buenaflor buenaflor marked this pull request as ready for review December 18, 2024 16:41
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one conditional import where we import the same file sprang into my eyes.

dart/lib/src/platform_checker.dart Show resolved Hide resolved
flutter/lib/src/navigation/sentry_navigator_observer.dart Outdated Show resolved Hide resolved
flutter/lib/src/sentry_flutter.dart Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants