-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sentry web api #2489
base: feat/js-sdk-integration
Are you sure you want to change the base?
feat: sentry web api #2489
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/js-sdk-integration #2489 +/- ##
============================================================
+ Coverage 70.98% 86.90% +15.92%
============================================================
Files 17 265 +248
Lines 579 9418 +8839
============================================================
+ Hits 411 8185 +7774
- Misses 168 1233 +1065 ☔ View full report in Codecov by Sentry. |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one conditional import where we import the same file sprang into my eyes.
Description
Allows type safe API access to underlying JS SDK
In this PR only
init
andclose
is implemented, more will follow in the next PRThe creating of the binding and the initialization is gated / opt-in through the
enableSentryJs
flag`💡 Motivation and Context
PR #2 of JS SDK Integration
💚 How did you test it?
Unit test, Integration Test, Manual Test
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
Sending envelope
#skip-changelog