-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beforeCapture
for View Hierarchy
#2523
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2523 +/- ##
==========================================
+ Coverage 86.96% 91.62% +4.65%
==========================================
Files 263 88 -175
Lines 9378 3091 -6287
==========================================
- Hits 8156 2832 -5324
+ Misses 1222 259 -963 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1cdcacf | 389.94 ms | 463.53 ms | 73.59 ms |
be08ed1 | 361.37 ms | 414.84 ms | 53.47 ms |
3ad66e4 | 406.90 ms | 481.48 ms | 74.58 ms |
ad69abc | 297.35 ms | 385.89 ms | 88.54 ms |
ef6466d | 373.96 ms | 443.17 ms | 69.21 ms |
e893df5 | 310.60 ms | 380.58 ms | 69.98 ms |
f25f207 | 341.40 ms | 427.73 ms | 86.34 ms |
61e71ec | 343.94 ms | 410.59 ms | 66.66 ms |
1131914 | 317.90 ms | 361.58 ms | 43.69 ms |
fe4aa56 | 356.06 ms | 428.67 ms | 72.61 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1cdcacf | 6.33 MiB | 7.26 MiB | 949.77 KiB |
be08ed1 | 6.33 MiB | 7.26 MiB | 946.42 KiB |
3ad66e4 | 6.33 MiB | 7.26 MiB | 947.04 KiB |
ad69abc | 6.06 MiB | 7.09 MiB | 1.03 MiB |
ef6466d | 6.34 MiB | 7.28 MiB | 967.79 KiB |
e893df5 | 6.06 MiB | 7.09 MiB | 1.03 MiB |
f25f207 | 6.33 MiB | 7.26 MiB | 943.41 KiB |
61e71ec | 6.34 MiB | 7.28 MiB | 966.26 KiB |
1131914 | 5.94 MiB | 6.96 MiB | 1.02 MiB |
fe4aa56 | 6.06 MiB | 7.10 MiB | 1.04 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9fe67d5 | 1242.33 ms | 1268.77 ms | 26.44 ms |
a775d3f | 1241.29 ms | 1241.53 ms | 0.24 ms |
103eb14 | 1254.11 ms | 1280.65 ms | 26.55 ms |
754cdbe | 1261.67 ms | 1280.88 ms | 19.20 ms |
408bdab | 1239.63 ms | 1257.61 ms | 17.98 ms |
fbf42af | 1253.76 ms | 1269.51 ms | 15.76 ms |
c73ab67 | 1267.73 ms | 1279.36 ms | 11.63 ms |
99704d2 | 1241.74 ms | 1258.00 ms | 16.26 ms |
bd1b990 | 1209.43 ms | 1226.96 ms | 17.53 ms |
4c13d97 | 1265.41 ms | 1287.95 ms | 22.55 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
9fe67d5 | 8.32 MiB | 9.50 MiB | 1.18 MiB |
a775d3f | 8.28 MiB | 9.34 MiB | 1.06 MiB |
103eb14 | 8.38 MiB | 9.71 MiB | 1.34 MiB |
754cdbe | 8.29 MiB | 9.37 MiB | 1.08 MiB |
408bdab | 8.28 MiB | 9.34 MiB | 1.06 MiB |
fbf42af | 8.16 MiB | 9.17 MiB | 1.01 MiB |
c73ab67 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
99704d2 | 8.42 MiB | 9.87 MiB | 1.44 MiB |
bd1b990 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
4c13d97 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
_debouncer = Debouncer( | ||
// ignore: invalid_use_of_internal_member | ||
_options.clock, | ||
waitTimeMs: 2000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
been only seeing this now but I think it's nicer and more 'dart-y' if we used a Duration instead of an int to represent the time.
so we can do waitTime: Duration(seconds: 2)
📜 Description
Add
beforeCapture
for View Hierarchy💡 Motivation and Context
Closes #2513
💚 How did you test it?
Tests
📝 Checklist
sendDefaultPii
is enabled