Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp: test ubuntu-24.04 #2533

Closed
wants to merge 2 commits into from
Closed

tmp: test ubuntu-24.04 #2533

wants to merge 2 commits into from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Dec 23, 2024

ubuntu-latest is switching to use ubuntu-24.04 so I want to prevent breakage when that happens, especially with upcoming releases.

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- test ubuntu-24.04 ([#2533](https://github.com/getsentry/sentry-dart/pull/2533))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 92a1ad8

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.12%. Comparing base (0764150) to head (92a1ad8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
+ Coverage   87.08%   87.12%   +0.04%     
==========================================
  Files         265      256       -9     
  Lines        9413     8814     -599     
==========================================
- Hits         8197     7679     -518     
+ Misses       1216     1135      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1253.73 ms 1273.51 ms 19.78 ms
Size 8.42 MiB 9.86 MiB 1.44 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
be173fa 1364.84 ms 1424.49 ms 59.65 ms
24f71aa 1267.47 ms 1272.00 ms 4.53 ms
7224aae 1246.78 ms 1268.35 ms 21.58 ms
9f9dd52 1364.63 ms 1394.89 ms 30.25 ms
abcdba3 1257.31 ms 1283.49 ms 26.18 ms
77db8d4 1228.47 ms 1248.80 ms 20.33 ms
905bf99 1240.84 ms 1271.47 ms 30.63 ms
cf91c9d 1217.08 ms 1233.00 ms 15.92 ms
1c6eb5b 1277.85 ms 1285.71 ms 7.86 ms
13f8952 1249.98 ms 1278.31 ms 28.33 ms

App size

Revision Plain With Sentry Diff
be173fa 8.33 MiB 9.54 MiB 1.22 MiB
24f71aa 8.10 MiB 9.16 MiB 1.07 MiB
7224aae 8.42 MiB 9.83 MiB 1.40 MiB
9f9dd52 8.33 MiB 9.63 MiB 1.29 MiB
abcdba3 8.15 MiB 9.12 MiB 989.76 KiB
77db8d4 8.38 MiB 9.73 MiB 1.35 MiB
905bf99 8.38 MiB 9.74 MiB 1.36 MiB
cf91c9d 8.33 MiB 9.40 MiB 1.07 MiB
1c6eb5b 8.15 MiB 9.12 MiB 986.27 KiB
13f8952 8.38 MiB 9.78 MiB 1.40 MiB

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 531.84 ms 625.00 ms 93.16 ms
Size 6.46 MiB 7.48 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3f3ef0b 382.24 ms 459.26 ms 77.02 ms
aa950e9 337.42 ms 400.72 ms 63.30 ms
e5b744f 302.70 ms 342.17 ms 39.47 ms
66e0270 369.04 ms 431.96 ms 62.92 ms
3500574 288.69 ms 358.34 ms 69.65 ms
b98109e 296.46 ms 362.68 ms 66.22 ms
4b29d6e 386.80 ms 430.86 ms 44.06 ms
d783424 302.08 ms 368.10 ms 66.02 ms
1d47eb7 282.26 ms 342.52 ms 60.26 ms
fe4aa56 356.06 ms 428.67 ms 72.61 ms

App size

Revision Plain With Sentry Diff
3f3ef0b 6.33 MiB 7.26 MiB 943.11 KiB
aa950e9 5.94 MiB 6.96 MiB 1.02 MiB
e5b744f 6.06 MiB 7.09 MiB 1.03 MiB
66e0270 6.35 MiB 7.35 MiB 1017.84 KiB
3500574 6.16 MiB 7.14 MiB 1009.90 KiB
b98109e 6.06 MiB 7.03 MiB 993.53 KiB
4b29d6e 6.33 MiB 7.26 MiB 946.14 KiB
d783424 6.16 MiB 7.14 MiB 1007.48 KiB
1d47eb7 6.16 MiB 7.14 MiB 1010.29 KiB
fe4aa56 6.06 MiB 7.10 MiB 1.04 MiB

@vaind vaind closed this Dec 23, 2024
@vaind vaind deleted the ci/test-ubuntu-24 branch December 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant