-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core)!: Remove standalone Client
interface & deprecate BaseClient
#14800
Open
mydea
wants to merge
2
commits into
develop
Choose a base branch
from
fn/client-type
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+126
−502
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
import type { | ||
Breadcrumb, | ||
BreadcrumbHint, | ||
Client, | ||
CheckIn, | ||
ClientOptions, | ||
DataCategory, | ||
DsnComponents, | ||
|
@@ -15,6 +15,7 @@ import type { | |
EventProcessor, | ||
FeedbackEvent, | ||
Integration, | ||
MonitorConfig, | ||
Outcome, | ||
ParameterizedString, | ||
SdkMetadata, | ||
|
@@ -71,7 +72,7 @@ const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing | |
* without a valid Dsn, the SDK will not send any events to Sentry. | ||
* | ||
* Before sending an event, it is passed through | ||
* {@link BaseClient._prepareEvent} to add SDK information and scope data | ||
* {@link Client._prepareEvent} to add SDK information and scope data | ||
* (breadcrumbs and context). To add more custom information, override this | ||
* method and extend the resulting prepared event. | ||
* | ||
|
@@ -81,15 +82,15 @@ const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing | |
* {@link Client.addBreadcrumb}. | ||
* | ||
* @example | ||
* class NodeClient extends BaseClient<NodeOptions> { | ||
* class NodeClient extends Client<NodeOptions> { | ||
* public constructor(options: NodeOptions) { | ||
* super(options); | ||
* } | ||
* | ||
* // ... | ||
* } | ||
*/ | ||
export abstract class BaseClient<O extends ClientOptions> implements Client<O> { | ||
export abstract class Client<O extends ClientOptions = ClientOptions> { | ||
/** Options passed to the SDK. */ | ||
protected readonly _options: O; | ||
|
||
|
@@ -243,6 +244,17 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> { | |
updateSession(session, { init: false }); | ||
} | ||
|
||
/** | ||
* Create a cron monitor check in and send it to Sentry. This method is not available on all clients. | ||
* | ||
* @param checkIn An object that describes a check in. | ||
* @param upsertMonitorConfig An optional object that describes a monitor config. Use this if you want | ||
* to create a monitor automatically when sending a check in. | ||
* @param scope An optional scope containing event metadata. | ||
* @returns A string representing the id of the check in. | ||
*/ | ||
public captureCheckIn?(checkIn: CheckIn, monitorConfig?: MonitorConfig, scope?: Scope): string; | ||
|
||
/** | ||
* @inheritDoc | ||
*/ | ||
|
@@ -452,7 +464,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> { | |
/** @inheritdoc */ | ||
public on( | ||
hook: 'beforeSendFeedback', | ||
callback: (feedback: FeedbackEvent, options?: { includeReplay: boolean }) => void, | ||
callback: (feedback: FeedbackEvent, options?: { includeReplay?: boolean }) => void, | ||
): () => void; | ||
|
||
/** @inheritdoc */ | ||
|
@@ -547,7 +559,7 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> { | |
public emit(hook: 'createDsc', dsc: DynamicSamplingContext, rootSpan?: Span): void; | ||
|
||
/** @inheritdoc */ | ||
public emit(hook: 'beforeSendFeedback', feedback: FeedbackEvent, options?: { includeReplay: boolean }): void; | ||
public emit(hook: 'beforeSendFeedback', feedback: FeedbackEvent, options?: { includeReplay?: boolean }): void; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this typed incorrectly before? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes! It differed between here and the type interface 😬 |
||
|
||
/** @inheritdoc */ | ||
public emit( | ||
|
@@ -948,6 +960,16 @@ export abstract class BaseClient<O extends ClientOptions> implements Client<O> { | |
): PromiseLike<Event>; | ||
} | ||
|
||
/** | ||
* @deprecated Use `Client` instead. This alias may be removed in a future major version. | ||
*/ | ||
export type BaseClient = Client; | ||
|
||
/** | ||
* @deprecated Use `Client` instead. This alias may be removed in a future major version. | ||
*/ | ||
export const BaseClient = Client; | ||
|
||
/** | ||
* Verifies that return value of configured `beforeSend` or `beforeSendTransaction` is of expected type, and returns the value if so. | ||
*/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we intentionally didn't add this to
BaseClient
, only to theServerRuntimeClient
so that check-in stays server-side specific.Why did we make this change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was in the type of
Client
. I merged this in as a type, but it is still optional! So not every client has to implement this method. I think that means nothing effectively should change?