Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add RN SDK package to sdk.packages for Cocoa #4381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR adds react native sdk package name and version to cocoa sdk packages.

This helps identify the exact version of rn sdk producing session replay.

This PR needs update of SentryCocoa with getsentry/sentry-cocoa#4637

💡 Motivation and Context

This help with debugging rn session replays.

💚 How did you test it?

sample app

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

Copy link
Contributor

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d8ebe79

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 369.62 ms 395.32 ms 25.70 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5a22220+dirty 384.61 ms 419.06 ms 34.45 ms
db44eaf+dirty 394.26 ms 438.88 ms 44.62 ms
9dabcce+dirty 359.66 ms 430.73 ms 71.08 ms
e22745e+dirty 415.50 ms 448.76 ms 33.26 ms
baa882f+dirty 449.30 ms 540.40 ms 91.10 ms
0d3e677+dirty 384.24 ms 431.45 ms 47.21 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
690220d+dirty 492.10 ms 473.88 ms -18.23 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms

App size

Revision Plain With Sentry Diff
5a22220+dirty 7.15 MiB 8.21 MiB 1.06 MiB
db44eaf+dirty 7.15 MiB 8.36 MiB 1.21 MiB
9dabcce+dirty 7.15 MiB 8.37 MiB 1.22 MiB
e22745e+dirty 7.15 MiB 8.35 MiB 1.20 MiB
baa882f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
0d3e677+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
690220d+dirty 7.15 MiB 8.36 MiB 1.21 MiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me 🚀
I restrain from approving till getsentry/sentry-cocoa#4637 is shipped with the next Cocoa SDK.
Similar to Android I'm not sure if getting the version from the react native options makes sense.

@krystofwoldrich
Copy link
Member Author

I've added a comment to the code versioning in the Android pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants