This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
(backwards incompatible) Model subst map in Gradle extension #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's much cleaner to put these substitutions in the buildscript than to put them in a file to be loaded from buildSrc.
|
Is there a matching issue for this? |
|
None filed yet; just figured it was better to share the changes I'd made. If you'd prefer a new issue to keep discussion about the problem separate from discussion about this particular proposed solution, feel free to create one. |
|
Just making sure I've not missed something |
|
It would probably make sense to make the file map to the new map, so it can at least, if we choose, to deprecate this in a future version. Would be a bit jarring for people who use a file to all of a sudden not be able to use the plugin without changes. Also, sorry for the late reply. I don't have much spare time anymore. |
gigaSproule
force-pushed
the
master
branch
3 times, most recently
from
765f1d7 to
8170522
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's much cleaner to put these substitutions in the buildscript than to put them in a file to be loaded from buildSrc.
Replaces the modelSubstitute option (resource file name) with a modelSubstitutions option (map of fromClass name to toClass name).
This PR probably shouldn't be accepted until someone (me, if I get time) adds some documentation updates. It also should probably be scheduled for the next major version bump, seeing as how it's backwards-incompatible.