feat: authenticate with github app installation and repo standardization #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeridth
force-pushed
the
jm-github-app-auth
branch
from
fe5862e to
87ff50b
Compare
jmeridth
changed the title
|
@zkoppert yes, I agree, this is HUGE. I feel a "rip the band aid off" moment allows for it. There is still an opportunity to split the auth and env stuff out like we do in cleanowners but this gets us in right direction. If you want me to split repo standardization and GitHub App Installation auth, please let me know. |
- [x] add ability to authenticate with GitHub App Installation
- [x] add tests for GitHub App Installation
- [x] add more tests for env vars
repo updates to match standards:
- [x] alphabetize :allthethings:
- [x] add requirements-test.txt to version our testing dependencies
- [x] update Makefile to point linting commands to our linter configs
that the GitHub Action workflows use
- [x] add linter configs
- [x] add checkov exemptions to Dockerfile
- custom user - can't do, need root for GitHub action workspace access
- [x] update README, splitting authentication section
- [x] change .pylintrc to .python-lint (pylint default config file)
- [x] updated all examples to default to read contents permissions
- [x] linted files
I'd highly suggest this be a major version change as there are breaking changes:
- [x] standardize boolean environment variables (true or false)
- [x] drop GITHUB_SERVER_URL and instead use GITHUB_ENTERPRISE_URL for enterprise
customers (matches our other repos)
Signed-off-by: jmeridth <[email protected]>
jmeridth
force-pushed
the
jm-github-app-auth
branch
from
87ff50b to
4fdfe82
Compare
|
The size of this change is daunting. There are 3 whole new files that are contributing:
|
|
Whoa. Looking into the issues. |
zkoppert
reviewed
Mar 22, 2024
Co-authored-by: Zack Koppert <[email protected]>
more to come Signed-off-by: jmeridth <[email protected]>
|
iterating through fixes. there are a decent amount. |
Signed-off-by: jmeridth <[email protected]>
Signed-off-by: jmeridth <[email protected]>
Signed-off-by: jmeridth <[email protected]>
replace comments with variables, causes ensured maintenance of meaning Signed-off-by: jmeridth <[email protected]>
zkoppert
changed the title
Signed-off-by: jmeridth <[email protected]>
Signed-off-by: jmeridth <[email protected]>
Signed-off-by: jmeridth <[email protected]>
- will reassess later Signed-off-by: jmeridth <[email protected]>
|
👀 |
zkoppert
reviewed
Mar 26, 2024
| """ | ||
| Get the environment variables for use in the script. | ||
|
|
||
| Returns EnvVars object with all environment variables | ||
| """ | ||
| if not test: |
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I'd highly suggest this be a major version bump (3.0.0) as there are breaking changes:
Willing to go the deprecation route but this is the simpler path.
GitHub App Installation:
Repo updates to match standards:
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking