-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to Node LTS #30
base: main
Are you sure you want to change the base?
Bump to Node LTS #30
Conversation
…ckage-lock from codespace build
…t for testing and remove node_modules and package-lock during post create if they already exist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @gfarb .
Have we tested all of these changes? We should think about ways to automatically test all of the workflows as a PR validating check. We'd probably need to do it in a fork, so that we could create our own environments in which to test everything.
@rdietrick yeah tested all of them in my fork, albeit that was a while ago it may be a good idea to run through another round of testing. I think I also need to look at dependencies and make sure they are all updated to avoid security "issues". I think that would be awesome if we could somehow create a validating check, will start to think about how we can accomplish this. Update:Before merging in this change in, I actually want to move forward with this PR #58 because this was tested a lot more extensively and is a bit more important |
.nvmrc
)Compile Release Notes
&Delete Artifacts
steps in.github/workflows/release-branch-merge-handler.yml
node_modules
to prevent error on rebuild