Refactor: Apply extract ids for search results #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 30, 2022
glensc
changed the title
|
I don't really understand what the next step is to use MixIn to simplify things: |
simonc56
requested changes
Dec 1, 2022
glensc
commented
Dec 1, 2022
| self._items.append(Person(item_data['name'], | ||
| item_data['slug'])) | ||
| extract_ids(item_data) | ||
| self._items.append(Person(**item_data)) | ||
|
|
||
| yield self._items |
There was a problem hiding this comment.
I noticed that UserList.get_items() has a bug, it always appends items to self._items. IMHO it should reset self._items = [] on each call to get_items().
Construct in a way that ids are filled properly
glensc
force-pushed
the
pts-1244-fix-v4
branch
from
52f2026 to
ea690b6
Compare
|
Probably useless after #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #9