Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use NamedTuple typing #28

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Refactor: Use NamedTuple typing #28

merged 7 commits into from
Apr 25, 2023

Conversation

glensc
Copy link
Owner

@glensc glensc commented Apr 18, 2023

Replaces moogar0880#190

NOTE: there appears Translation being present in movie.py and tv.py. and they are not even identical.

NOTE: Can't have NamedTuple and __init__, so UserList stays as namedtuple()

UPDATE: Copied DataClassMixin trick from:

@glensc glensc self-assigned this Apr 18, 2023
@glensc glensc force-pushed the 190-NamedTuple-typing branch from 4904700 to 8b5ca32 Compare April 18, 2023 18:21
@glensc glensc force-pushed the 190-NamedTuple-typing branch from 0f9a447 to 327668d Compare April 18, 2023 20:25
@glensc glensc force-pushed the 190-NamedTuple-typing branch from 327668d to 6dd9ff2 Compare April 18, 2023 20:30
@glensc glensc force-pushed the 190-NamedTuple-typing branch from 6dd9ff2 to 3c3d379 Compare April 18, 2023 20:31
@glensc glensc requested a review from simonc56 April 20, 2023 17:56
@simonc56
Copy link
Collaborator

Tested successfully with plextraktsync 0.26.4 and liked_lists: true 👍

@glensc glensc merged commit 3e59b19 into main Apr 25, 2023
@glensc glensc deleted the 190-NamedTuple-typing branch April 25, 2023 10:55
@glensc
Copy link
Owner Author

glensc commented Apr 25, 2023

i recall i tested like this

diff --git a/trakt/users.py b/trakt/users.py
index 4a8b33e..14714c3 100644
--- a/trakt/users.py
+++ b/trakt/users.py
@@ -88,6 +88,7 @@ class UserList(DataClassMixin(UserListTuple), IdsMixin):
 
     def __init__(self, ids=None, **kwargs):
         super().__init__(**kwargs)
+        print(f"Created userlist: {self.data}")
         self._ids = ids
         self._items = list()
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants